Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12540


Change subject: Reduce startup log spam
......................................................................

Reduce startup log spam

This eliminates a lot of the messages at startup that really aren't
useful:

1. No more of this:

I0220 13:18:51.160027 372970944 ts_tablet_manager.cc:1007] T 
2f7ecbdb5c564106a2646ffe5f21f347 P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.161830 372970944 ts_tablet_manager.cc:1007] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.162523 372970944 ts_tablet_manager.cc:1007] T 
58f1243dad6346549370fbe50a739563 P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.163156 372970944 ts_tablet_manager.cc:1007] T 
c4fc7d7a16e34f4aa87e1af2e1defa2e P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.163739 372970944 ts_tablet_manager.cc:1007] T 
28d12a741054442d988646178daad91f P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.164413 372970944 ts_tablet_manager.cc:1007] T 
0048470f677242dda0277aed2fef7b05 P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
I0220 13:18:51.165114 372970944 ts_tablet_manager.cc:1007] T 
2b9dc70391f54e3fbf116b46d86c2c50 P 0a909baebce949a6aa4cdc0f196ecd00: Loading 
tablet metadata
...

Instead, just a pair of summary messages:

I0220 15:15:29.755679 323278272 ts_tablet_manager.cc:344] Loading tablet 
metadata (0/60 complete)
I0220 15:15:29.803109 323278272 ts_tablet_manager.cc:356] Loaded tablet 
metadata (60 total tablets, 60 live tablets)

2. No more of this:

I0220 13:18:51.200745 372970944 ts_tablet_manager.cc:1175] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
I0220 13:18:51.201200 372970944 ts_tablet_manager.cc:1175] T 
58f1243dad6346549370fbe50a739563 P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
I0220 13:18:51.201637 372970944 ts_tablet_manager.cc:1175] T 
c4fc7d7a16e34f4aa87e1af2e1defa2e P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
I0220 13:18:51.202126 372970944 ts_tablet_manager.cc:1175] T 
28d12a741054442d988646178daad91f P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
I0220 13:18:51.202700 372970944 ts_tablet_manager.cc:1175] T 
0048470f677242dda0277aed2fef7b05 P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
I0220 13:18:51.203141 372970944 ts_tablet_manager.cc:1175] T 
2b9dc70391f54e3fbf116b46d86c2c50 P 0a909baebce949a6aa4cdc0f196ecd00: Registered 
tablet (data state: TABLET_DATA_READY)
...

Instead, just a pair of summary messages:

I0220 15:15:29.803143 323278272 ts_tablet_manager.cc:362] Registering tablets 
(0/60 complete)
I0220 15:15:29.822479 323278272 ts_tablet_manager.cc:376] Registered 60 tablets

3. Condense webserver startup messages. Instead of

I0220 13:18:51.234637 372970944 webserver.cc:175] Starting webserver on 
127.0.0.1:8050
I0220 13:18:51.234654 372970944 webserver.cc:180] Document root: 
/Users/wdberkeley/src/kudu/www
I0220 13:18:51.235159 372970944 webserver.cc:313] Webserver started. Bound to: 
http://127.0.0.1:8050/

just

I0220 15:15:29.834751 323278272 webserver.cc:307] Webserver started at 
http://127.0.0.1:8050/ using document root /Users/wdberkeley/src/kudu/www and 
password file <none>

Note that the protocol 'http://' will now correctly show as 'https://'
if the webserver is configured for SSL.

4. I got rid of some of the highest level, lowest info content messages
   about the "tablet server starting", because that just means we
   finished executed code in tablet_server_main.cc, not that the tablet
   server is ready to do anything in particular.

Note that this gets rid of a variety of sorta useful messages about
bootstrapping, e.g.

I0220 13:18:51.359330 230735872 ts_tablet_manager.cc:1030] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: 
Bootstrapping tablet
I0220 13:18:51.359630 230735872 tablet_bootstrap.cc:438] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Bootstrap 
starting.
I0220 13:18:51.483634 230735872 tablet_bootstrap.cc:438] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Bootstrap 
replayed 1/1 log segments. Stats: ops{read=63 overwritten=0 applied=63 
ignored=62} inserts{seen=0 ignored=0} mutations{seen=0 ignored=0} 
orphaned_commits=0. Pending: 0 replicates
I0220 13:18:51.484174 230735872 tablet_bootstrap.cc:438] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Bootstrap 
complete.

It does not get rid of the most useful one:

I0220 13:18:51.484905 230735872 ts_tablet_manager.cc:1047] T 
27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Time spent 
bootstrapping tablet: real 0.126s  user 0.106s     sys 0.014s

A follow up will expand this information to provide more metrics on
bootstrap, so don't mourn the loss of the above messages.

Change-Id: I3793a2385612cf920a94e5f62a559c350b8bf461
---
M src/kudu/server/webserver.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/tablet_server_main.cc
M src/kudu/tserver/ts_tablet_manager.cc
4 files changed, 34 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12540/1
--
To view, visit http://gerrit.cloudera.org:8080/12540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3793a2385612cf920a94e5f62a559c350b8bf461
Gerrit-Change-Number: 12540
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <[email protected]>

Reply via email to