Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12540 )
Change subject: Reduce startup log spam ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12540/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12540/1//COMMIT_MSG@66 PS1, Line 66: I0220 13:18:51.483634 230735872 tablet_bootstrap.cc:438] T 27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Bootstrap replayed 1/1 log segments. Stats: ops{read=63 overwritten=0 applied=63 ignored=62} inserts{seen=0 ignored=0} mutations{seen=0 ignored=0} orphaned_commits=0. Pending: 0 replicates > I'm very conflicted about this message and the timing messages. They are pe I agree with you re: all of the online tooling that would be better than the logs. IMO logs in general are helpful for looking at what happened, not what's happening, and so keeping around timing info, markers indicating important state changes, etc. (especially in a sea of other log messages from other tablets, from consensus, etc) _may_ be useful to have. I agree with most of these changes, since many don't add much info other than where in the code we are, but the timing message seems useful, at least as an indicator of IO. Same with the bootstrapping details -- seems like it's got enough info to be useful, and I'm not well versed enough in bootstrapping to say they'd never be useful again (maybe there are WAL-related bugs in which this logging is useful). Looking at a history of these logs, https://github.com/apache/kudu/commits/7c6ba1cb34107383077d8985354f716791cc8622, seems like they were introduced when we were fixing/testing WALs. -- To view, visit http://gerrit.cloudera.org:8080/12540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3793a2385612cf920a94e5f62a559c350b8bf461 Gerrit-Change-Number: 12540 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 04:12:46 +0000 Gerrit-HasComments: Yes
