Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12540 )
Change subject: Reduce startup log spam ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/12540/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12540/1//COMMIT_MSG@66 PS1, Line 66: I0220 13:18:51.483634 230735872 tablet_bootstrap.cc:438] T 27705b0198da406d8301830cd942c7ee P 0a909baebce949a6aa4cdc0f196ecd00: Bootstrap replayed 1/1 log segments. Stats: ops{read=63 overwritten=0 applied=63 ignored=62} inserts{seen=0 ignored=0} mutations{seen=0 ignored=0} orphaned_commits=0. Pending: 0 replicates > I agree with you re: all of the online tooling that would be better than th OK. Let's leave this message then. Without doing some more surgery on bootstrap, this means I need to leave the "Boostrap starting" message as well. http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/server/webserver.cc@167 PS1, Line 167: parts.push_back(addr.ToString() + (IsSecure() ? "s" : "")); > warning: 'push_back' is called inside a loop; consider pre-allocating the v Done http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/server/webserver.cc@293 PS1, Line 293: /*styled=*/true, /*on_nav_bar=*/true); > warning: argument name 'on_nav_bar' in comment does not match parameter nam Done http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/server/webserver.cc@293 PS1, Line 293: /*styled=*/true, /*on_nav_bar=*/true); > warning: argument name 'styled' in comment does not match parameter name 'i Done http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/tablet/tablet_bootstrap.cc@438 PS1, Line 438: VLOG(1) << Substitute("T $0 P $1: $2", > Can use VLOG_WITH_PREFIX here? Done http://gerrit.cloudera.org:8080/#/c/12540/1/src/kudu/tserver/tablet_server_main.cc File src/kudu/tserver/tablet_server_main.cc: PS1: > nit: maybe, remove similar messages from master_main.cc as well? Done -- To view, visit http://gerrit.cloudera.org:8080/12540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3793a2385612cf920a94e5f62a559c350b8bf461 Gerrit-Change-Number: 12540 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 18:21:39 +0000 Gerrit-HasComments: Yes
