Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/12517/15/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/12517/15/src/kudu/master/master-test.cc@909 PS15, Line 909: FLAGS_log_filename = "kudu-master"; > How does it fail? L935 is a glob of FLAGS_log_dir which has been set. How d Failure Expected: 1 To be equal to: log_paths.size() Which is: 0 The glob won't match because when the Master is initialized, ServerBase::StartMetricsLogging is called which creates a new DiagnosticsLog, this DiagnosticsLog uses FLAGS_log_filename as the program_name. That DiagnosticLog is a RollingLog that would end up having the format of: program.host.user.diagnostics.timestamp.sequence.pid When the program is "" in the case of logs not being initialized this makes a file with a leading . which is "hidden" and not globed. -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 15 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 22:55:29 +0000 Gerrit-HasComments: Yes
