Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/12517/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12517/13//COMMIT_MSG@16 PS13, Line 16: appoximately approximately http://gerrit.cloudera.org:8080/#/c/12517/13//COMMIT_MSG@29 PS13, Line 29: neccessary necessary http://gerrit.cloudera.org:8080/#/c/12517/12/src/kudu/master/master_runner.h File src/kudu/master/master_runner.h: PS12: > Do you feel strongly about this? No, I don't feel strongly about this. I just thought this piece looks like a good refactoring on its own and separating this piece would help to separate the essence of the new functionality in the kudu CLI. If you prefer to keep it along, that's completely fine with me. http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/rolling_log.h File src/kudu/util/rolling_log.h: PS11: > Do you feel strongly about this? No, I don't feel strongly about this. If you prefer to keep it along, that's completely fine with me. -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 00:23:54 +0000 Gerrit-HasComments: Yes
