Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/12517/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12517/11//COMMIT_MSG@24 PS11, Line 24: inclued > nit: included Done http://gerrit.cloudera.org:8080/#/c/12517/12/src/kudu/master/master_runner.h File src/kudu/master/master_runner.h: PS12: > Maybe, separate this and the related change in tablet_server_runner.{h,cc} Do you feel strongly about this? I like having it in this patch given the change is only motivated by this change/functionality and has no benefit on it's own outside of this change. http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/flags.h File src/kudu/util/flags.h: http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/flags.h@58 PS11, Line 58: // Should be called after logging is initialized. Otherwise : // logging will write to stderr. > nit: This was a little surprising because it implies that it has an effect This is more of a glog detail than a detail of this function, I just mention this here so callers are aware given this is a function that could be called early enough to be before logging is initialized. It's also why I broke these calls out from HandleCommonFlags(). You will see this in our test logs all the time when we don't initialize logging: WARNING: Logging before InitGoogleLogging() is written to STDERR http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/rolling_log.h File src/kudu/util/rolling_log.h: PS11: > maybe, put this update and the places where it's used (diagnostics_log.cc, Do you feel strongly about this? I like having it in this patch given the change is only motivated by this change/functionality and has no benefit on it's own outside of this change. -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 12 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 23:49:23 +0000 Gerrit-HasComments: Yes
