Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12613 )
Change subject: KUDU-2711 (part 1): add a benchmark for GetTableLocations ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc@326 PS1, Line 326: const int kNumReactors = 8; Curious why not have kNumThreads == kNumReactors? http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc@383 PS1, Line 383: &LOG(INFO) Neat, didn't know you could get an ostream that way. http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.h File src/kudu/util/hdr_histogram.h: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.h@171 PS1, Line 171: void DumpHumanReadable(std::ostream* out) const; Maybe some light documentation, since the rest of the functions are fairly well documented? -- To view, visit http://gerrit.cloudera.org:8080/12613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1643638d82b7697d20ea960592c8b70c30ac7bd Gerrit-Change-Number: 12613 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 00:31:58 +0000 Gerrit-HasComments: Yes
