Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12613 )
Change subject: KUDU-2711 (part 1): add a benchmark for GetTableLocations ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc@326 PS1, Line 326: const int kNumSplits = FLAGS_benchmark_num_tablets - 1; > Curious why not have kNumThreads == kNumReactors? I'm not sure what Todd's reason was, but I tested using a single messenger and #reactors = #threads and it seemed to perform roughly the same after some light testing. http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc@358 PS1, Line 358: for (int i = 0; i < kNumThreads; i++) { > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/integration-tests/table_locations-itest.cc@383 PS1, Line 383: > Neat, didn't know you could get an ostream that way. :themoreyouknow: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.h File src/kudu/util/hdr_histogram.h: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.h@168 PS1, Line 168: // TODO(mpercy): implement > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.h@171 PS1, Line 171: // Dump a formatted, multiline string describing this histogram to 'out'. > Maybe some light documentation, since the rest of the functions are fairly Done http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.cc File src/kudu/util/hdr_histogram.cc: http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.cc@328 PS1, Line 328: HdrHistogram::DumpHumanReadable > Consider using this to dump the histograms in rpc-bench.cc. Done -- To view, visit http://gerrit.cloudera.org:8080/12613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1643638d82b7697d20ea960592c8b70c30ac7bd Gerrit-Change-Number: 12613 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 20:12:10 +0000 Gerrit-HasComments: Yes
