Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12613 )

Change subject: KUDU-2711 (part 1): add a benchmark for GetTableLocations
......................................................................


Patch Set 1:

(1 comment)

I wrote an eerily similar patch yesterday (at least, the body of the test was 
very similar).

http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.cc
File src/kudu/util/hdr_histogram.cc:

http://gerrit.cloudera.org:8080/#/c/12613/1/src/kudu/util/hdr_histogram.cc@328
PS1, Line 328: HdrHistogram::DumpHumanReadable
Consider using this to dump the histograms in rpc-bench.cc.



--
To view, visit http://gerrit.cloudera.org:8080/12613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1643638d82b7697d20ea960592c8b70c30ac7bd
Gerrit-Change-Number: 12613
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Wed, 27 Feb 2019 01:02:45 +0000
Gerrit-HasComments: Yes

Reply via email to