Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12614 )
Change subject: KUDU-2711 (part 2): use a RWMutex for TSDescriptor ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12614/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12614/1//COMMIT_MSG@12 PS1, Line 12: This patch changes the spinlock to an rw_spinlock. > I agree with that. I tested with both an RWMutex and an rw_spinlock on ve05 The numbers in the commit message paint a rosier picture. Comparing the 'count' from RWMutex to rw_spinlock shows a ~15% improvement. Curious where you got the 5% from? -- To view, visit http://gerrit.cloudera.org:8080/12614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id48635e49f11d20fa1802b17a3ff5771632dfd01 Gerrit-Change-Number: 12614 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2019 00:12:28 +0000 Gerrit-HasComments: Yes
