Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12614 )
Change subject: KUDU-2711 (part 2): use a RWMutex for TSDescriptor ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12614/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12614/1//COMMIT_MSG@12 PS1, Line 12: This patch changes the spinlock to an rw_spinlock. > The numbers in the commit message paint a rosier picture. Comparing the 'co Seems hard to compare my numbers vs Will's numbers. Not sure we ran the benchmarks on the same host http://gerrit.cloudera.org:8080/#/c/12614/1//COMMIT_MSG@45 PS1, Line 45: 99.99% = 13440 > Not clear. In general, the variance of some "extreme" sort of sample variab Agreed, the 99.99th percentile of 22000 samples is determined by just the two worst samples http://gerrit.cloudera.org:8080/#/c/12614/2/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/12614/2/src/kudu/master/ts_descriptor.cc@333 PS2, Line 333: new consensus::ConsensusServiceProxy( : messenger, addr, std::move(host)) > nit: maybe, allocate new ConsensusServiceProxy() outside of the locked scop then you'd have to do another round of double-checked locking or something. I think this code path is cold enough it's not worth it -- To view, visit http://gerrit.cloudera.org:8080/12614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id48635e49f11d20fa1802b17a3ff5771632dfd01 Gerrit-Change-Number: 12614 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2019 05:49:51 +0000 Gerrit-HasComments: Yes
