Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12614 )
Change subject: KUDU-2711 (part 2): use a RWMutex for TSDescriptor ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12614/2/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/12614/2/src/kudu/master/ts_descriptor.cc@310 PS2, Line 310: ts_admin_proxy_.reset(new tserver::TabletServerAdminServiceProxy( : messenger, addr, std::move(host))); nit: maybe,allocate new TabletServerAdminServiceProxy() outside of the lock and to ts_admin_proxy_ under the lock? It might help to save a few cycles of contention. Also, if that's a first call to GetLoggedInUser(), the benefits are much greater. http://gerrit.cloudera.org:8080/#/c/12614/2/src/kudu/master/ts_descriptor.cc@333 PS2, Line 333: new consensus::ConsensusServiceProxy( : messenger, addr, std::move(host)) nit: maybe, allocate new ConsensusServiceProxy() outside of the locked scope and put the consensus_proxy_.reset() under the lock only? That's not much, but it could save a few hundred (?) cycles. -- To view, visit http://gerrit.cloudera.org:8080/12614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id48635e49f11d20fa1802b17a3ff5771632dfd01 Gerrit-Change-Number: 12614 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2019 00:36:32 +0000 Gerrit-HasComments: Yes
