Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] added test to repro deadlock on logging ...................................................................... Patch Set 1: (5 comments) How http://gerrit.cloudera.org:8080/#/c/12740/1//COMMIT_MSG Commit Message: PS1: How often does it deadlock? I wonder if it'd deadlock more often if the Subprocess was run in a loop for some number of seconds. May only need one logging thread at that point. http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@373 PS1, Line 373: LOG(INFO) << Substitute("$0: $1", thread_idx, i); Should explain why each thread logs and sleeps. http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@385 PS1, Line 385: Subprocess p({ "/nonexistent.file" }); Nit: any particular reason to use an absolute path here? Not that I would expect anyone to have an executable named /nonexistent.file, but if you tried to run it directly in the CWD, it's _definitely_ not there. http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@387 PS1, Line 387: ASSERT_OK(p.Start()); Could maybe simplify with Subprocess::Call? The barrier point would come "earlier" (since the subprocess creation happens inside Call) but I doubt that would matter. http://gerrit.cloudera.org:8080/#/c/12740/1/src/kudu/util/subprocess-test.cc@388 PS1, Line 388: int wait_status = 0; Nit: does it need to be initialized? -- To view, visit http://gerrit.cloudera.org:8080/12740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67 Gerrit-Change-Number: 12740 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 04:27:41 +0000 Gerrit-HasComments: Yes
