Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: KUDU-2743 [subprocess] test to repro deadlock in Subproces::Run() ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: http://gerrit.cloudera.org:8080/#/c/12740/4/src/kudu/util/subprocess-test.cc@397 PS4, Line 397: ASSERT_TRUE(s.IsRuntimeError()) << s.ToString(); > Isn't this already done by the SCOPED_CLEANUP? Indeed. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/12740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67 Gerrit-Change-Number: 12740 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:11:38 +0000 Gerrit-HasComments: Yes
