Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12740 )
Change subject: [subprocess] test to repro deadlock in Subproces::Run() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: http://gerrit.cloudera.org:8080/#/c/12740/3/src/kudu/util/subprocess-test.cc@375 PS3, Line 375: for (auto i = 0; i < 250; ++i) { why not have a while (!done) with a atomic<bool> done set by the main thread? ie loop the logger threads until the subprocesses have finished their loop of attempts, and then shut down, instead of this hard-coded 250? -- To view, visit http://gerrit.cloudera.org:8080/12740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie88073bb7fcccf24b4451fe3c4e4cd8bd471ca67 Gerrit-Change-Number: 12740 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 16:18:36 +0000 Gerrit-HasComments: Yes
