Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12876 )
Change subject: [util] change signature of Cache::Allocate() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h@193 PS1, Line 193: // memory usage or caching pointers to objects of a non-trivial type. Nit: a little ambiguous given its placement in the sentence. How about "...memory usage. It is also useful when caching items for whom calculating memory usage is a complex affair (i.e. items containing pointers to additional heap allocations)." http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h@198 PS1, Line 198: into Nit: "in a" http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h@225 PS1, Line 225: virtual Handle* Insert(UniquePendingHandle pending, We could change Insert, Lookup, and Release to return/accept UniqueHandles, then do the same kind of Handle* -> UniqueHandle transformation that you just did in this patch. -- To view, visit http://gerrit.cloudera.org:8080/12876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6 Gerrit-Change-Number: 12876 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 03:36:44 +0000 Gerrit-HasComments: Yes
