Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12876 )
Change subject: [util] change return type of Cache::Allocate() ...................................................................... [util] change return type of Cache::Allocate() This patch changes the signature of Cache::Allocate() and Cache::Insert() methods to be explicit on the ownership of the memory allocated behind Cache::PendingHandle. Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6 Reviewed-on: http://gerrit.cloudera.org:8080/12876 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/block_cache.cc M src/kudu/cfile/block_cache.h M src/kudu/codegen/code_cache.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/util/cache-bench.cc M src/kudu/util/cache-test.cc M src/kudu/util/cache.cc M src/kudu/util/cache.h M src/kudu/util/file_cache.cc M src/kudu/util/nvm_cache.cc 10 files changed, 96 insertions(+), 78 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6 Gerrit-Change-Number: 12876 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
