Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12876 )
Change subject: [util] change return type of Cache::Allocate() ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/12876/1/src/kudu/util/cache.h@225 PS1, Line 225: // If 'eviction_callback' is non-NULL, then it will be called when the > Yes, that sounds like an improvement as well. Is it OK to do that in a sep Sure. -- To view, visit http://gerrit.cloudera.org:8080/12876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6 Gerrit-Change-Number: 12876 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 05:00:21 +0000 Gerrit-HasComments: Yes
