Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 6: (2 comments) Whoops, it seems I missed a typo in the commit message while looking at the patch last time. http://gerrit.cloudera.org:8080/#/c/11754/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11754/9//COMMIT_MSG@22 PS9, Line 22: endpoinat endpoint http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc@485 PS6, Line 485: CHECK_GT > Depending on num_to_return may end up returning the full list anyway. Right, so my point was why not to make it universal in that sense, given that the CHECK_GT() seemed to be there only because of some artificial restriction and '%' operator. Anyway, that was just a nit, feel free to ignore. -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Mar 2019 05:07:02 +0000 Gerrit-HasComments: Yes
