Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 6: (4 comments) a few more nits: it seems I missed those last review round, sorry. http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc@485 PS6, Line 485: CHECK_GT nit: why not to be able to return up to the all the list, randomized? i.e. CHECK_GE() here and int num_to_return = min_to_return + rand() % (full_list.size() - min_to_return + 1) below? http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc@1110 PS6, Line 1110: static vector<RowOperationsPB::Type> write_op_types = { nit: add const? Otherwise it looks like every call is supposed to modify write_op_types. http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc@1124 PS6, Line 1124: static vector<WritePrivilegeType> write_privilege_types { nit: ditto http://gerrit.cloudera.org:8080/#/c/11754/6/src/kudu/tserver/tablet_server_authorization-test.cc@1231 PS6, Line 1231: .op_type = RowOperationsPB::INSERT, : .key = 0, : .val = 0, I don't think we want to use C99 extensions in our code. Maybe, just list the values for the fields in order. -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 27 Mar 2019 17:32:45 +0000 Gerrit-HasComments: Yes
