Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM, just minor nits. http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tablet/transactions/write_transaction.h File src/kudu/tablet/transactions/write_transaction.h: http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tablet/transactions/write_transaction.h@247 PS4, Line 247: nit: then. http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tablet/transactions/write_transaction.h@288 PS4, Line 288: nit: transaction. -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 27 Mar 2019 03:42:28 +0000 Gerrit-HasComments: Yes
