Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )
Change subject: [HaClient] introduce client metrics ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/catalog_manager.cc@4680 PS5, Line 4680: optional<const string&> user) { > warning: the parameter 'user' is copied for each invocation but only used a I'm going to ignore this TidyBot's comment in the scope of this patch. http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744 PS5, Line 744: // NotAuthorized() from Sentry itself considered as a fatal error. : // TODO(aserbin): is it a bug in HaClient or Sentry itself? > Yeah, I'm curious about this. Is there a distinction between the errors tha I'm not going to get into the bottom of it in the context of this change, but I opened a JIRA for that: https://issues.apache.org/jira/browse/KUDU-2769 I updated the comment as well to mention the JIRA case above. -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Apr 2019 19:07:22 +0000 Gerrit-HasComments: Yes
