Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )
Change subject: [HaClient] introduce client metrics ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744 PS5, Line 744: // NotAuthorized() from Sentry itself considered as a fatal error. : // TODO(aserbin): is it a bug in HaClient or Sentry itself? > We have tests in sentry_client-test.cc for cases when Sentry sends back Not Yeah, I filed KUDU-2769 to clarify on that, because reconnecting seems to be sub-optimal in those cases. -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Apr 2019 20:49:12 +0000 Gerrit-HasComments: Yes
