Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )
Change subject: [HaClient] introduce client metrics ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744 PS5, Line 744: // NotAuthorized() from Sentry itself considered as a fatal error. : // TODO(KUDU-2769): clarify whether it is a bug in HaClient > Great, thanks for filing that! We have tests in sentry_client-test.cc for cases when Sentry sends back NotAuthorized() error. For example, Sentry fails to find a user's group mapping. Though I think in these cases we should not retry? -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Apr 2019 20:40:22 +0000 Gerrit-HasComments: Yes
