Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13291 )
Change subject: [master_sentry-itest] one more scenario for authz cache ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h@53 PS2, Line 53: uint32_t sentry_client_rpc_retry_num = 3, : uint32_t sentry_client_rpc_retry_interval_ms = 500); nit: maybe add a comment explaining that these are the defaults in some version of Sentry? Or that they are set low for tests? http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h@119 PS2, Line 119: uint32_t sentry_client_rpc_retry_num_; : uint32_t sentry_client_rpc_retry_interval_ms_; We should try to avoid using unsigned where we can: https://google.github.io/styleguide/cppguide.html#Integer_Types -- To view, visit http://gerrit.cloudera.org:8080/13291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d3c04e4137afff407e4db8ee39a4495d9add3dc Gerrit-Change-Number: 13291 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 May 2019 17:09:36 +0000 Gerrit-HasComments: Yes
