Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13291 )
Change subject: [master_sentry-itest] one more scenario for authz cache ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13291/3/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/13291/3/src/kudu/integration-tests/master_sentry-itest.cc@908 PS3, Line 908: / CreateTable() with operation timeout longer than HMS --> Sentry : // communication timeout successfully completes. After failing to push : // the information on the newly created table to Sentry due to the logic : // implemented in the SentrySyncHMSNotificationsPostEventListener plugin, : // HMS sends success response to Kudu master and Kudu successfully completes : // the rest of the steps. : ASSERT_OK(CreateKuduTable(kDatabaseName, kGhostTables[0])); : : // In this case, the timeout for the CreateTable RPC is set to be lower than : // the HMS --> Sentry communication timeout (see corresponding parameters : // of the MiniHms::EnableSentry() method). CreateTable() successfully passes : // the authz phase since the information on privileges is cached and no : // Sentry RPC calls are attempted. However, since Sentry is down, : // CreateTable() takes a long time on the HMS's side and the client's : // request times out, while the creation of the table continues in the : // background. > Thank you for the feedback! Yeah, returning Incomplete() Status seems find to me. We can address this in a follow up patch. Thanks a lot for working on this! http://gerrit.cloudera.org:8080/#/c/13291/3/src/kudu/integration-tests/master_sentry-itest.cc@927 PS3, Line 927: s.IsTimedOut( > Right, that's because the timeout for the operation was longer than the tim ACK. -- To view, visit http://gerrit.cloudera.org:8080/13291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d3c04e4137afff407e4db8ee39a4495d9add3dc Gerrit-Change-Number: 13291 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 00:59:33 +0000 Gerrit-HasComments: Yes
