Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13291 )
Change subject: [master_sentry-itest] one more scenario for authz cache ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h@53 PS2, Line 53: rpc_retry_interval_ms' are used to override default settings : // of the Sentry client used by HMS plugins. The default values for th > nit: maybe add a comment explaining that these are the defaults in some ver Done http://gerrit.cloudera.org:8080/#/c/13291/2/src/kudu/hms/mini_hms.h@119 PS2, Line 119: std::string keytab_file_; : rpc::SaslProtection::Type protection_ = rpc::S > We should try to avoid using unsigned where we can: Yeah, that guide, being written by Java adepts, has many strange statements. Unsigned types have a nice property to overflow safely, but signed types have no such one. De facto, size_t is unsigned, and everything related to size in stdlib is unsigned :) Anyway, done. -- To view, visit http://gerrit.cloudera.org:8080/13291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d3c04e4137afff407e4db8ee39a4495d9add3dc Gerrit-Change-Number: 13291 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 May 2019 21:16:46 +0000 Gerrit-HasComments: Yes
