Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13308 )
Change subject: [java] Fix handling of SERVICE_UNAVAILABLE errors ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > Could we test this? Set up a test scenario where the client > receives a service unavailable error, then prove (using RPC > metrics?) that it doesn't bounce to the master for a new lookup? I worry that has flaky potential, e.g. if the service unavailable error is received, but then on retry the leader stepped down and it triggers a master lookup. It'd be nicer if we had a good way to test this error handling code without needing a running cluster. FWIW, I was running a BDR test workload and seeing tons of silly GTLs logged by the client. I tried using the client with this patch and saw those GTLs no more. http://gerrit.cloudera.org:8080/#/c/13308/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java: http://gerrit.cloudera.org:8080/#/c/13308/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@418 PS1, Line 418: if (exception instanceof InvalidAuthnTokenException) { > Can these invalid token exceptions actually happen? It looks like the calle I program defensively in the Java client. If all callers take care of authn exceptions, then handling authn exceptions here doesn't hurt; if not, then this helps. Eventually, I'd like to (or I'd like someone else to) refactor this code so it's easy to understand and I don't feel like I need to be so defensive when handling errors. -- To view, visit http://gerrit.cloudera.org:8080/13308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3437c779322e756a6e1fbc19f464f765741d58b Gerrit-Change-Number: 13308 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 16:51:38 +0000 Gerrit-HasComments: Yes
