Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13308 )
Change subject: [java] Fix handling of SERVICE_UNAVAILABLE errors ...................................................................... Patch Set 1: > (1 comment) > > > (1 comment) > > > > > (1 comment) > > > > > > Could we test this? Set up a test scenario where the client > > > receives a service unavailable error, then prove (using RPC > > > metrics?) that it doesn't bounce to the master for a new > lookup? > > > > I worry that has flaky potential, e.g. if the service unavailable > > error is received, but then on retry the leader stepped down and > it > > triggers a master lookup. It'd be nicer if we had a good way to > > test this error handling code without needing a running cluster. > > > > FWIW, I was running a BDR test workload and seeing tons of silly > > GTLs logged by the client. I tried using the client with this > patch > > and saw those GTLs no more. > > Maybe, using single-master test cluster could help to avoid > leader-related uncertainty here? > > BTW, it seems we have some unit-test like coverage in > TestHandleTooBusy.java. Maybe, it's possible to add a new test > scenario in there? Ah, TestHandleTooBusy.java relies on real test cluster to be around: it's not a good reference for mock-like scenarios. >From the other side, maybe you could piggy-back on RPC traces here? Anyway, >if you think that piece doesn't need extra-coverage and you verified it works, >maybe having it as-is good enough :) -- To view, visit http://gerrit.cloudera.org:8080/13308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3437c779322e756a6e1fbc19f464f765741d58b Gerrit-Change-Number: 13308 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 22:24:02 +0000 Gerrit-HasComments: No
