Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13308 )
Change subject: [java] Fix handling of SERVICE_UNAVAILABLE errors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13308/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java: http://gerrit.cloudera.org:8080/#/c/13308/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@418 PS1, Line 418: if (exception instanceof InvalidAuthnTokenException) { > I program defensively in the Java client. If all callers take care of authn If this is meant to be refactored, could you add a TODO here or at the callsite in responseReceived() mentioning that this duplication is intentional and defensive, and that it'd be nice to refactor this stuff to be more obviously correct? I could see myself coming back to this without that context and being confused why we have this handling twice, when it seems to be exercised once (at least for now). -- To view, visit http://gerrit.cloudera.org:8080/13308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3437c779322e756a6e1fbc19f464f765741d58b Gerrit-Change-Number: 13308 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 21:08:50 +0000 Gerrit-HasComments: Yes
