Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13320 )
Change subject: [backup] Factor out kudu-backup-tools module ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13320/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13320/1//COMMIT_MSG@12 PS1, Line 12: it’s its http://gerrit.cloudera.org:8080/#/c/13320/1/java/gradle/shadow.gradle File java/gradle/shadow.gradle: http://gerrit.cloudera.org:8080/#/c/13320/1/java/gradle/shadow.gradle@53 PS1, Line 53: Our shaded library jars always try to pull in the slf4j api from : // kudu-client For my own edification, what does this mean? The shaded jars depend on slf4j api, which we don't want to include in the jar but by default will be included, so we are specifically excluding it? http://gerrit.cloudera.org:8080/#/c/13320/1/java/kudu-backup-tools/build.gradle File java/kudu-backup-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/13320/1/java/kudu-backup-tools/build.gradle@27 PS1, Line 27: dependencies { As I understand it, this doesn't restrict the versions the tools can work with. E.g., if someone is backing up to HDFS x.y but the tool was built for x.(y + 1), the tool will still work on HDFS x.y as long as we aren't using new features of the x.(y + 1) API. The same thing is true for Spark? What about Scala and Java? We include Scala of a particular version. Does that limit what Java versions we run on in a way that you think could be limiting, like preventing us from running a tool one or two versions newer against an older Hadoop + Spark cluster? -- To view, visit http://gerrit.cloudera.org:8080/13320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ef2c21fbc31b11b20f0588b6de3cd4998b67443 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 17:16:01 +0000 Gerrit-HasComments: Yes
