Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13320 )
Change subject: [backup] Factor out kudu-backup-tools module ...................................................................... Patch Set 1: > > Should we also include a log4j.properties in main/resources? > > Yes please. We currently use the same log4j.properties in each module, and > that consistency gives us the right logging for tests. Sorry, I misunderstood and misread. This patch does include a log4j.properties in src/test/resources; Mike is asking about src/main/resources. I don't have any opinions on that. -- To view, visit http://gerrit.cloudera.org:8080/13320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ef2c21fbc31b11b20f0588b6de3cd4998b67443 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 18:14:29 +0000 Gerrit-HasComments: No
