Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13320 )
Change subject: [backup] Factor out kudu-backup-tools module ...................................................................... Patch Set 1: (1 comment) Thanks for creating this module. http://gerrit.cloudera.org:8080/#/c/13320/1/java/kudu-backup/build.gradle File java/kudu-backup/build.gradle: http://gerrit.cloudera.org:8080/#/c/13320/1/java/kudu-backup/build.gradle@23 PS1, Line 23: compile(project(path: ":kudu-backup-tools")) { Don't we need backup-tools to be a leaf dependency if we are shipping it as a fully shaded fat jar, or that doesn't matter in the Gradle world because we will publish multiple variations of it? (with and without deps) -- To view, visit http://gerrit.cloudera.org:8080/13320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ef2c21fbc31b11b20f0588b6de3cd4998b67443 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 17:31:55 +0000 Gerrit-HasComments: Yes
