helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13376 )
Change subject: [util] Support for table and tablet filtering in metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13376/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/13376/1/src/kudu/util/metrics.cc@220 PS1, Line 220: bool select_all = MatchMetricInList(id(), requested_metrics); This line of code is a bit strange, except that it skips matching the following metrics. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/13376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee Gerrit-Change-Number: 13376 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 06:45:47 +0000 Gerrit-HasComments: Yes
