Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13376 )
Change subject: [util] Support for table and tablet filtering in metrics ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13376/2/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/13376/2/src/kudu/util/metrics.cc@205 PS2, Line 205: bool MatchTableInList(const string& table_id, const vector<string>& table_ids) { Can we make this patch more generic to matching entity types/entity ids? The kudu/util/ package is meant to be generic/reusable across projects (eg Impala shares this code). Impala isn't currently using our metrics system but would prefer to keep it generic and reusable. -- To view, visit http://gerrit.cloudera.org:8080/13376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee Gerrit-Change-Number: 13376 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 16:21:08 +0000 Gerrit-HasComments: Yes
