Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13376 )
Change subject: [util] Support for table and tablet filtering in metrics ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13376/2/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13376/2/src/kudu/util/metrics.h@409 PS2, Line 409: struct MetricFilterOptions { Can you move this functionality into MetricJsonOptions? I don't really see the value of separating the two kinds of options. http://gerrit.cloudera.org:8080/#/c/13376/2/src/kudu/util/metrics.h@666 PS2, Line 666: const std::vector<std::string>& requested_metrics, Since 'opts' is going to gain more advanced filtering capabilities, would be nice to move requested_metrics in there too, so that all the filtering is described in one place. -- To view, visit http://gerrit.cloudera.org:8080/13376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ca55bd1f0f3d4107cb208f6f855d24121823ee Gerrit-Change-Number: 13376 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 17:54:11 +0000 Gerrit-HasComments: Yes
