Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 )
Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange ...................................................................... Patch Set 30: (2 comments) http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2039 PS30, Line 2039: LOG.debug("Add key range {}", newRange); > Is the test failure issue potentially a real issue, or just a test issue? Yeah we need to get to the bottom of this. I didn't see this debug output anywhere in the test failure. The failure was: 1) testScanWithKeyRange(org.apache.kudu.spark.kudu.DefaultSourceTest) org.scalatest.junit.JUnitTestFailedError: [[50,50,50,50.0,50,false,50,50.0,[B@6a4d57b7,2019-05-17 05:54:47.22 5,50,50,50,50], [51,51,null,51.0,51,true,51,51.0,[B@a36ff0b,2019-05-17 05:54:47.258,51,51,51,51], [52,52,52,5 2.0,52,false,52,52.0,[B@1ecf784f,2019-05-17 05:54:47.269,52,52,52,52], [53,53,null,53.0,53,true,53,53.0,[B@34 4769b9,2019-05-17 05:54:47.283,53,53,53,53], ... That output isn't particularly useful either. Specifically, the [B@... refers to the address of a byte array and should be replaced with something more useful. I looped DefaultSourceTest 1000 times. You can see the results here: http://dist-test.cloudera.org/job?job_id=adar.1558472309.107999 Looks like: - 461 tests passed - 142 tests failed - 397 tests were canceled I haven't looked at all of the failures, but the few I looked at all failed in the same way: the new test got 1950 rows instead of 1000. http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@1046 PS30, Line 1046: assert(results.size() == rowCount * 100) Could you use assertEquals here? -- To view, visit http://gerrit.cloudera.org:8080/12323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0502f5d64569e8b1d45e88de3cb36aa2e01234d0 Gerrit-Change-Number: 12323 Gerrit-PatchSet: 30 Gerrit-Owner: yangz <zhe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: yangz <zhe...@gmail.com> Gerrit-Comment-Date: Tue, 21 May 2019 21:20:19 +0000 Gerrit-HasComments: Yes
