Yao Xu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12323 )

Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange
......................................................................


Patch Set 32:

(1 comment)

Thanks Adar for the test result. I added the information of the primary key 
range in AsyncKuduScanner.toString. The reason for the problem should be that 
KeyRange is duplicate.
In the following log, the tablet(79e027fcb6bd4f67b85028ab7d08352c) primary key 
range is duplicate.

13:07:31.784 [DEBUG - New I/O worker #158] (AsyncKuduClient.java:2039) Add key 
range [<start>, <end>), 40603, "79e027fcb6bd4f67b85028ab7d08352c" [0x80000032, 
<end>)
13:07:31.784 [DEBUG - New I/O worker #157] (AsyncKuduClient.java:2039) Add key 
range [<start>, <end>), 35286, "453294f2eb9341cfb4e59964404fc4e0" [<start>, 
0x80000032)
13:07:31.785 [DEBUG - New I/O worker #158] (AsyncKuduClient.java:2039) Add key 
range [<start>, <end>), 40603, "79e027fcb6bd4f67b85028ab7d08352c" [0x80000032, 
<end>)

http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:

http://gerrit.cloudera.org:8080/#/c/12323/30/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@1046
PS30, Line 1046:       assertEquals(rowCount * 100, results.size())
> Could you use assertEquals here?
Done



--
To view, visit http://gerrit.cloudera.org:8080/12323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0502f5d64569e8b1d45e88de3cb36aa2e01234d0
Gerrit-Change-Number: 12323
Gerrit-PatchSet: 32
Gerrit-Owner: yangz <zhe...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com>
Gerrit-Reviewer: yangz <zhe...@gmail.com>
Gerrit-Comment-Date: Wed, 22 May 2019 13:35:48 +0000
Gerrit-HasComments: Yes

Reply via email to