Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 )
Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange ...................................................................... Patch Set 33: Code-Review+2 > I found the root cause of this problem. Because Deferred.group no guarantee > on the order of the results in the deferred list returned, but we rely on the > return order when we call PartitionPruner.removePartitionKeyRange, This will > cause some KeyRange to be created repeatedly. It's my fault. :( Nice, glad you were able to get to the bottom of it. > Btw, dist-test seems to be a good test tools. Is there any doc for it? Unfortunately there aren't because it has some significant limitations: 1. Submitted tests must be built on el6 or Ubuntu 14 hosts. 2. There's no sandboxing or resource controls in place, so a malicious user can use dist-test to e.g. mine bitcoin. For that reason, we haven't shared the credentials outside Cloudera. We should work towards making it available to the broader community, but for now if you want something looped with dist-test, don't hesitate to ask a Cloudera engineer who works on Kudu. BTW, I looped DefaultSourceTest with the fix 1000 times. It passed 999/1000, with the one failure being unrelated. -- To view, visit http://gerrit.cloudera.org:8080/12323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0502f5d64569e8b1d45e88de3cb36aa2e01234d0 Gerrit-Change-Number: 12323 Gerrit-PatchSet: 33 Gerrit-Owner: yangz <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: yangz <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 05:15:25 +0000 Gerrit-HasComments: No
