Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13412 )
Change subject: KUDU-2826: Add tail for mutation list to accelerate update in memrowset ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/memrowset.h@150 PS3, Line 150: // NOTE: this call is O(n) in the number of mutations, since it has to walk : // the linked list all the way to the end, checking if each mutation is a : // DELETE or REINSERT. We expect the list is usually short (low-update use : // cases) but if this becomes a bottleneck, we could cache the 'ghost' status : // as a bit inside the row header. > Yes, the o(n) behavior will be a bottleneck when update frequently so I t Gotcha, thanks for the confirmation! -- To view, visit http://gerrit.cloudera.org:8080/13412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I945f332f8241ecb3cc6ab66e67ee3ee2b4e49be8 Gerrit-Change-Number: 13412 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 04:44:29 +0000 Gerrit-HasComments: Yes
