Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13412 )
Change subject: KUDU-2826: Add tail for mutation list to accelerate update in memrowset ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/mutation.cc File src/kudu/tablet/mutation.cc: http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/mutation.cc@54 PS3, Line 54: void Mutation::AppendToListAtomic(Mutation** redo_head, Mutation** redo_tail) { > Agree with you. Because kudu writes the row with lock, so this function wil Could you document these semantics in the function comment in mutation.h? It's important because if the concurrency semantics for writers change, this will be wrong. -- To view, visit http://gerrit.cloudera.org:8080/13412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I945f332f8241ecb3cc6ab66e67ee3ee2b4e49be8 Gerrit-Change-Number: 13412 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 18:38:04 +0000 Gerrit-HasComments: Yes
