ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13412 )
Change subject: KUDU-2826: Add tail for mutation list to accelerate update in memrowset ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/mutation.cc File src/kudu/tablet/mutation.cc: http://gerrit.cloudera.org:8080/#/c/13412/3/src/kudu/tablet/mutation.cc@54 PS3, Line 54: void Mutation::AppendToListAtomic(Mutation** redo_head, Mutation** redo_tail) { > Could you document these semantics in the function comment in mutation.h? I // Append this mutation to the list at the given pointer. // Redo_tail should be used by writers only and redo_head by readers only. // This function has the semantics like "atomic" under the condition that // only a single writer and concurrent readers can access a given row. If // concurrent writers access this function for the same row, pointers will // disagree and lead to error. void AppendToListAtomic(Mutation** redo_head, Mutation** redo_tail); Is that comment clearly explain the problem? -- To view, visit http://gerrit.cloudera.org:8080/13412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I945f332f8241ecb3cc6ab66e67ee3ee2b4e49be8 Gerrit-Change-Number: 13412 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 03:10:17 +0000 Gerrit-HasComments: Yes
