Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 1) ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver-test.cc File src/kudu/util/net/dns_resolver-test.cc: http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver-test.cc@88 PS4, Line 88: LOG(INFO) << Substitute("$0 non-cached resolutions of '$1' took $2", > Are 1000 iterations of non-cached DNS lookup fast enough for this test? The test tries to resolve localhost, so it's fast enough. It usually takes under half a second (at least for my macOS build). http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver.h File src/kudu/util/net/dns_resolver.h: http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver.h@82 PS4, Line 82: typedef TTLCache<std::string, std::vector<Sockaddr>> HostRecordCache; > Should doc what the keys and values are. Done http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver.cc File src/kudu/util/net/dns_resolver.cc: http://gerrit.cloudera.org:8080/#/c/13266/4/src/kudu/util/net/dns_resolver.cc@105 PS4, Line 105: resolved_addresses > Should use cached_addresses here for consistency. Ah, indeed. Good catch! -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2019 07:10:55 +0000 Gerrit-HasComments: Yes
