Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: WIP KUDU-2791: TTL cache in DNS resolver (part 1) ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13266/3/src/kudu/util/net/dns_resolver.h File src/kudu/util/net/dns_resolver.h: http://gerrit.cloudera.org:8080/#/c/13266/3/src/kudu/util/net/dns_resolver.h@73 PS3, Line 73: class AsyncDnsResolver: public DnsResolver { > I looked at the implementation and I see what you're saying. But doesn't th SGTM. I merged sync and async interfaces into a single class. However, I don't use the pool&synchronizer approach for synchronous resolution since it's not necessary as of now. -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2019 01:29:33 +0000 Gerrit-HasComments: Yes
