Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: [dns_resolver] KUDU-2791 TTL cache in DNS resolver ...................................................................... Patch Set 2: > Probably, that means the DNS cache should be a singleton accessed by > HostPort::ResolveAddresses(), or the code could be refactored to use > DnsResolver elsewhere, but then it needs to have 'synchronous' mode or alike. Would prefer not to introduce a new singleton (though of course that depends on the plumbing challenges involved). Synchronous mode shouldn't be bad; just a new function call that calls the async function with a Synchronizer. -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 04:21:50 +0000 Gerrit-HasComments: No
