Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13606 )
Change subject: KUDU-2836: Release memory to OS periodically ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG@9 PS1, Line 9: reserve > reserved Done http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG@10 PS1, Line 10: operating > operating Done http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG@11 PS1, Line 11: fill > fill Done http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG@11 PS1, Line 11: increases > increases Done http://gerrit.cloudera.org:8080/#/c/13606/1//COMMIT_MSG@13 PS1, Line 13: This patch adds a background thread to periodically GC tcmalloc > adds Done http://gerrit.cloudera.org:8080/#/c/13606/1/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/13606/1/src/kudu/server/server_base.cc@209 PS1, Line 209: 3600 > How did you arrive at this default value? Really not consider much about it. It depends on the speed of memory consumed. http://gerrit.cloudera.org:8080/#/c/13606/1/src/kudu/server/server_base.cc@678 PS1, Line 678: MonoDelta gc_interval; : do { : gc_interval = MonoDelta::FromSeconds(FLAGS_gc_tcmalloc_memory_interval_seconds > 0 : ? FLAGS_gc_tcmalloc_memory_interval_seconds : 60); : if (FLAGS_gc_tcmalloc_memory_interval_seconds > 0) { : kudu::process_memory::GcTcmalloc(); : } : } while (!stop_background_threads_latch_.WaitFor(gc_interval)); : } : #endif : : std::string ServerBase::FooterHtml() const { : r > How about something like this: Done -- To view, visit http://gerrit.cloudera.org:8080/13606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb3529ed53c250f69e5faf5b2a067b2abce06c0 Gerrit-Change-Number: 13606 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 05:53:14 +0000 Gerrit-HasComments: Yes
