Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13606 )
Change subject: KUDU-2836: Release memory to OS periodically ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/integration-tests/memory_gc-itest.cc File src/kudu/integration-tests/memory_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/integration-tests/memory_gc-itest.cc@55 PS6, Line 55: &generic_current_allocated_bytes)); > This is OK, but I wonder if it would be easier to fetch Done http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/integration-tests/memory_gc-itest.cc@87 PS6, Line 87: ASSERT_GE(work > nit: rename to GetOverheadRatio (a ratio is between 0 and 1, but a percent Done http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/integration-tests/memory_gc-itest.cc@138 PS6, Line 138: > typo Done http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/integration-tests/memory_gc-itest.cc@167 PS6, Line 167: > why do we need to test this once per tserver? I think just running this tes Done http://gerrit.cloudera.org:8080/#/c/13606/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/13606/3/src/kudu/server/server_base.cc@211 PS3, Line 211: DEFINE_uint64(gc_tcmalloc_memory_interval_seconds, 30, > is once an hour often enough? from your graphs you uploaded on the JIRA it Done http://gerrit.cloudera.org:8080/#/c/13606/3/src/kudu/server/server_base.cc@682 PS3, Line 682: // If GC is disabled, wake up every 60 seconds anyway to recheck the value of the flag. : check_interval = MonoDelta::FromSeconds(FLAGS_gc_tcmalloc_memory_interval_seconds > 0 : ? FLAGS_gc_tcmalloc_memory_interval_seconds : 60) > I think this could be clearer if you rename 'gc_interval' to 'check_interva Done http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/13606/6/src/kudu/server/server_base.cc@211 PS6, Line 211: DEFINE_uint64(gc_tcmalloc_memory_interval_seconds, 30, > Let's default this to 30 seconds or something. Otherwise I think a lot of m Done -- To view, visit http://gerrit.cloudera.org:8080/13606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb3529ed53c250f69e5faf5b2a067b2abce06c0 Gerrit-Change-Number: 13606 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 06:39:09 +0000 Gerrit-HasComments: Yes
