Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13606 )

Change subject: KUDU-2836: Release memory to OS periodically
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13606/3//COMMIT_MSG
Commit Message:

PS3:
Would it make sense to add a test to verify the behavior is as  expected with 
regard to the setting for the --tcmalloc_max_free_bytes_percentage ?  Probably, 
it might be done with very active read workload (see TestWorkload in 
src/kudu/integration_tests/test_workload.h and it usage in various tests) and 
setting the --gc_tcmalloc_memory_interval_seconds flag to something low (like 5 
seconds or alike).  The information about current tcmalloc metrics might be 
retrieved from the /memz page of the embedded webserver.



--
To view, visit http://gerrit.cloudera.org:8080/13606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb3529ed53c250f69e5faf5b2a067b2abce06c0
Gerrit-Change-Number: 13606
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Thu, 13 Jun 2019 18:08:09 +0000
Gerrit-HasComments: Yes

Reply via email to