Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )
Change subject: KUDU-2850: fix thrift comparison ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc File src/kudu/sentry/thrift_operators.cc: http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc@35 PS1, Line 35: if ((lhs) != (rhs)) { \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc@36 PS1, Line 36: return (lhs) < (rhs); \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done -- To view, visit http://gerrit.cloudera.org:8080/13608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c Gerrit-Change-Number: 13608 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 13 Jun 2019 08:23:33 +0000 Gerrit-HasComments: Yes
