Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13608 )
Change subject: KUDU-2850: fix thrift comparison ...................................................................... KUDU-2850: fix thrift comparison In the operator< implementations, we previously wouldn't return early when determining that a field in the LHS was greater than that in the RHS, when we should have returned false. I added a test for each operator I updated that would fail without this patch. Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c Reviewed-on: http://gerrit.cloudera.org:8080/13608 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Grant Henke <[email protected]> --- M src/kudu/sentry/thrift_operators-test.cc M src/kudu/sentry/thrift_operators.cc 2 files changed, 82 insertions(+), 33 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c Gerrit-Change-Number: 13608 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
